Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing test for banner stripping trailing newlines during parsing #569

Merged
merged 3 commits into from
Sep 17, 2024
Merged

failing test for banner stripping trailing newlines during parsing #569

merged 3 commits into from
Sep 17, 2024

Conversation

jeffkala
Copy link
Collaborator

No description provided.

@jeffkala
Copy link
Collaborator Author

Really this line is the problem

netutils/netutils/config/parser.py

Line 226 in ceb1693

line = banner.rstrip() + end

Trailing newlines in a banner are valid in Cisco and in many cases like the login banner they're almost required to avoid the login banner from overrunning the password prompt.

Changing the line above to rstrip(' '). does fix the issue but causes all banner tests to fail so believe it would require a major release to make this change.

@jeffkala jeffkala marked this pull request as ready for review September 10, 2024 17:46
@jeffkala jeffkala merged commit b33408e into develop Sep 17, 2024
38 checks passed
@jeffkala jeffkala deleted the jkala-banner-newline-strip branch September 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks itdependsnetworks approved these changes

@qduk qduk Awaiting requested review from qduk qduk is a code owner

@abates abates Awaiting requested review from abates abates is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffkala @itdependsnetworks